Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating beatmaps removes them from collections #19346

Closed
camellirite opened this issue Jul 24, 2022 · 3 comments · Fixed by #19431
Closed

Updating beatmaps removes them from collections #19346

camellirite opened this issue Jul 24, 2022 · 3 comments · Fixed by #19431
Assignees
Labels
realm deals with local realm database

Comments

@camellirite
Copy link

Type

Game behaviour

Bug description

How to replicate:

  1. Include a beatmap that needs updating in a collection
  2. Update the beatmap

Screenshots or videos

2022-07-24.15-12-40.mp4

Version

2022.723.0

Logs

logs.zip

@peppy
Copy link
Member

peppy commented Jul 24, 2022

Collections are based on hash, so this makes sense. I guess we may need special logic to handle this flow for updates.

@peppy peppy added the realm deals with local realm database label Jul 24, 2022
@peppy peppy self-assigned this Jul 25, 2022
@peppy
Copy link
Member

peppy commented Jul 25, 2022

Optimally, this would be fixed by first moving collections to realm to save having a second flow to manage the updates. @smoogipoo thoughts on this? Do we want to keep the current collection database model to maintain compatibility, or is that a good direction to implement immediately?

@smoogipoo
Copy link
Contributor

We could always still provide the option to import/export collections, just not store them as collections.db. The reader/writer would be super simple, probably 1/10th the amount of lines in that class already. I do believe it's a good direction.

@peppy peppy moved this to In Progress in osu! development roadmap Jul 27, 2022
@peppy peppy moved this from In Progress to In Review in osu! development roadmap Jul 28, 2022
Repository owner moved this from In Review to Done in osu! development roadmap Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
realm deals with local realm database
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants