-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add collection transfer logic to beatmap import-as-update flow #19431
Add collection transfer logic to beatmap import-as-update flow #19431
Conversation
To confirm, the editor will at some point be updated to use the |
Yeah, that sounds like a good direction (at very least having |
|
||
importAfterUpdate.PerformRead(updated => | ||
{ | ||
updated.Realm.Refresh(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how to feel about this being done inside this nested context as opposed to realm.Run(r => r.Refresh());
like all the other methods (on master
).
But at the end of the day this is still being run on the same context as the former, so I'll let it slide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured this was safer because as you say, the context might be different otherwise (this ensures it definitely isn't).
Closes #19346
And to answer a question asked elsewhere "why was it necessary to move collections to realm to make this work?", the only answer I have is "i didn't want to pass a
CollectionManager
in toBeatmapImporter
". Also because the deeper I got in beatmap collection code, the more I felt it required a refactor pass.