Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parent OnRevertResult is not invoked by nested HitObjects #23069

Closed
LumpBloom7 opened this issue Mar 31, 2023 · 1 comment · Fixed by #23185
Closed

Parent OnRevertResult is not invoked by nested HitObjects #23069

LumpBloom7 opened this issue Mar 31, 2023 · 1 comment · Fixed by #23185
Assignees
@bdach
Labels
area:ruleset-api priority:0 Showstopper. Critical to the next release.

Comments

@LumpBloom7
Copy link
Contributor

Type

Game behaviour

Bug description

Previously, when a nested DrawableHitObject had their results reverted, they would invoke OnRevertResult of their parent.

This behaviour is removed in #22291, but the comments above DrawableHitObject.OnRevertResult remain unchanged, leading to difference in expected behaviour.

Screenshots or videos

No response

Version

2023.326.1

Logs

N/A
@LumpBloom7 LumpBloom7 mentioned this issue Mar 31, 2023
Merged
@peppy peppy added the priority:0 Showstopper. Critical to the next release. label Apr 3, 2023
@peppy
Copy link
Member

peppy commented Apr 3, 2023

Going to drop this in p0 for now since it was a regression in ruleset API.

@bdach bdach self-assigned this Apr 11, 2023
@bdach bdach mentioned this issue Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdach bdach

Labels
area:ruleset-api priority:0 Showstopper. Critical to the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Invoke RevertResult on parent DHO when nested DHO is reverted bdach/osu
3 participants
@peppy @LumpBloom7 @bdach