Invoke RevertResult on parent DHO when nested DHO is reverted
#23185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Covering nested object reverts not firing the parent's `RevertResult` event in accordance with what the xmldoc of the event states.
The behaviour described above was removed in 812a4b4, thus henceforth contradicting `RevertResult`'s xmldoc. As it is relied on by some external rulesets, bring it back to unbreak them.
|
Can confirm it to be working as it used to. :) |
peppy
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23069.
It appears to be this easy and tests are passing locally with this change, but maybe I'm missing something. Would appreciate a review from @ekrctb to confirm/deny.
@LumpBloom7 would appreciate you taking a look at the change and confirming that this fixes the breakage you're seeing.