Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when arriving at results screen from multiplayer spectator #24445

Closed
peppy opened this issue Aug 2, 2023 · 2 comments · Fixed by #24548
Closed

Crash when arriving at results screen from multiplayer spectator #24445

peppy opened this issue Aug 2, 2023 · 2 comments · Fixed by #24548
Assignees
@peppy
Labels
area:multiplayer priority:0 Showstopper. Critical to the next release. type:reliability

Comments

@peppy
Copy link
Member

peppy commented Aug 2, 2023 

[runtime] 2023-08-02 08:38:04 [error]: An unhandled error has occurred.
[runtime] 2023-08-02 08:38:04 [error]: System.AggregateException: One or more errors occurred. (Index was outside the bounds of the array.)
[runtime] 2023-08-02 08:38:04 [error]: ---> System.IndexOutOfRangeException: Index was outside the bounds of the array.
[runtime] 2023-08-02 08:38:04 [error]: at System.Collections.Generic.Dictionary`2.CopyEntries(Entry[] entries, Int32 count)
[runtime] 2023-08-02 08:38:04 [error]: at System.Collections.Generic.Dictionary`2.AddRange(IEnumerable`1 collection)
[runtime] 2023-08-02 08:38:04 [error]: at osu.Game.Scoring.ScoreInfo.DeepClone() in /Users/dean/Projects/osu/osu.Game/Scoring/ScoreInfo.cs:line 177
[runtime] 2023-08-02 08:38:04 [error]: at osu.Game.Scoring.Score.DeepClone() in /Users/dean/Projects/osu/osu.Game/Scoring/Score.cs:line 18
[runtime] 2023-08-02 08:38:04 [error]: at osu.Game.Screens.Play.Player.<prepareAndImportScoreAsync>b__113_0() in /Users/dean/Projects/osu/osu.Game/Screens/Play/Player.cs:line 815
[runtime] 2023-08-02 08:38:04 [error]: --- End of inner exception stack trace ---
[runtime] 2023-08-02 08:38:04 [error]: at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
[runtime] 2023-08-02 08:38:04 [error]: at System.Threading.Tasks.Task`1.GetResultCore(Boolean waitCompletionNotification)
[runtime] 2023-08-02 08:38:04 [error]: at osu.Game.Screens.Play.Player.<progressToResults>b__112_0() in /Users/dean/Projects/osu/osu.Game/Screens/Play/Player.cs:line 776
[runtime] 2023-08-02 08:38:04 [error]: at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
[runtime] 2023-08-02 08:38:04 [error]: at osu.Framework.Threading.Scheduler.Update()
[runtime] 2023-08-02 08:38:04 [error]: at osu.Framework.Graphics.Drawable.UpdateSubTree()
[runtime] 2023-08-02 08:38:04 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
@peppy peppy added priority:0 Showstopper. Critical to the next release. area:multiplayer type:reliability labels Aug 2, 2023
@ppy-sentryintegration
Copy link

Sentry issue: OSU-F0N

@ppy-sentryintegration
Copy link

Sentry issue: OSU-FAB

@peppy peppy self-assigned this Aug 14, 2023
peppy added a commit to peppy/osu that referenced this issue Aug 15, 2023
@peppy
Fix score being cloned in async method causing random crashes
e8bde65 
Closes ppy#24445.
@peppy peppy mentioned this issue Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peppy peppy

Labels
area:multiplayer priority:0 Showstopper. Critical to the next release. type:reliability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix score being cloned in async method causing random crashes peppy/osu
1 participant
@peppy