Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching beatmap sound plays when exiting gameplay #25875

Closed
Stoppedpuma opened this issue Dec 18, 2023 · 5 comments · Fixed by #25943
Closed

Switching beatmap sound plays when exiting gameplay #25875

Stoppedpuma opened this issue Dec 18, 2023 · 5 comments · Fixed by #25943
Assignees
@peppy
Labels
area:song-select audio priority:1 Very important. Feels bad without fix. Affects the majority of users.

Comments

@Stoppedpuma
Copy link
Contributor

Stoppedpuma commented Dec 18, 2023 •
edited
Loading

Type

Game behaviour

Bug description

The switching maps sound effect will play on the beatmap into when spamming left click.

Only happens when going from song select into the map, not from retrying.

Screenshots or videos

switch_sound_issue.mp4

Version

2023.1218.1

Logs

shorter_runtime.log
@Stoppedpuma
Copy link
Contributor Author

Seems to play even without pressing left click as well

@JacksonChen666 JacksonChen666 mentioned this issue Dec 19, 2023
Closed
@OliBomby
Copy link
Contributor

I noticed this sound often also comes associated with a lag spike for me. Considering the lag spike always happens when this 'switching beatmap' sound plays, i figured it might be related. The lag only happens when I have the song select sorted by Difficulty. I also have like 100k beatmaps imported which might be related.

osu._GglxzrLNIV.mp4

@bdach bdach added area:song-select audio priority:1 Very important. Feels bad without fix. Affects the majority of users. labels Dec 19, 2023
@bdach bdach mentioned this issue Dec 19, 2023
Closed
@peppy peppy self-assigned this Dec 20, 2023
@peppy
Copy link
Member

peppy commented Dec 20, 2023

I think this might be related to ongoing background processing. @OliBomby can you confirm that your background processing is still running when this happens? You should also be able to cancel it via the notification if it is, and confirm that fixes the issue.

@peppy peppy changed the title Switching beatmap sound plays when spamming left click during intro screen of beatmaps Switching beatmap sound plays when exiting gameplay Dec 20, 2023
@peppy
Copy link
Member

peppy commented Dec 20, 2023

Scratch that, this is a regression from the hotfix fixing the last regression.

@peppy
Copy link
Member

peppy commented Dec 20, 2023

Clicking is not required to make this happen.

peppy added a commit to peppy/osu that referenced this issue Dec 20, 2023
@peppy
Fix song select running updates when screen is not active
64f62e7 
Who would have guessed that `Schedule` calls were there for a reason!

I've tidied things up. Most of the changes I've made here are not
required – the schedule is the main thing here. The reason the sound was
playing is because one-too-many schedules was removed causing beatmap
updates to update carousel specifics while still at the player loader
screen.

Note that the selection sound still plays on returning to song select,
but this is not a regression. I'm looking at fixing this in a separate
PR because I'm in a good place as far as understanding the logic right
now and it would be a waste to leave it broken.

Closes ppy#25875.
@peppy peppy mentioned this issue Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peppy peppy

Labels
area:song-select audio priority:1 Very important. Feels bad without fix. Affects the majority of users.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix song select running updates when screen is not active peppy/osu
4 participants
@peppy @OliBomby @bdach @Stoppedpuma