Recent 20ms delay added to visual waveform cause some songs to render out of bound.

[Trung0246]

Type

Cosmetic

Bug description

I believe this is the root cause: #26136

Is it possible to move the constant to a separate settings and set that value to 20 if we intend to keep that constant?

Affected songs:
https://osu.ppy.sh/beatmapsets/2047843#osu/4275701
https://osu.ppy.sh/beatmapsets/1312305#osu/2719816
https://osu.ppy.sh/beatmapsets/1846720#osu/3793506
https://osu.ppy.sh/beatmapsets/1017505#osu/2129555

All of these songs have the characteristic of 0ms offset timing.

Screenshots or videos

Version

2023.1229.0-lazer

Logs

compressed-logs.zip

[peppy]

I believe you are misunderstanding. You NEED to time to the new offset as all players expect this timing.

You cannot use external waveforms to time. osu! beatmaps have an offset and with this change we calculated the offset to be applied to bring all waveforms in line.