Add visual offset to better align editor waveforms with expectations #26136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
added
the
next release
|
Seems to be closer visually. I did no platform testing on this (only windows) but because this is pure visual offset platform doesn't matter I believe? |
bdach
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21947.
Discussion and testing happened on discord, although I wouldn't recommend reading that as part of the review, just noting that it did happen and should be pretty accurate.
Testing was done
In preparation for locking in better audio constants in lazer, let's fix the editor waveform looking completely misaligned.
This adds a visual-only offset to better align the editor waveform (in the timeline and on the timing screen) with osu! community expectations. With this change, visual-based timing is feasible, and assuming done correctly, should be accurate within 2 ms.