Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast typing makes issues when changing sample volume #28713

Closed
rvneXe opened this issue Jul 2, 2024 · 4 comments · Fixed by ppy/osu-framework#6328
Closed

Fast typing makes issues when changing sample volume #28713

rvneXe opened this issue Jul 2, 2024 · 4 comments · Fixed by ppy/osu-framework#6328

Comments

@rvneXe
Copy link

rvneXe commented Jul 2, 2024

Type

Game behaviour

Bug description

Hi. As you can see in this video, I'm trying to change those volumes to "60" but it looks like my 0 overwrites the 6

2024-07-02_19-34-23.mp4

Screenshots or videos

No response

Version

2024.625.2

Logs

compressed-logs.zip

@frenzibyte
Copy link
Member

You can select multiple objects and adjust the volume of all of them at once (although you will have to do it for each piece of the slider, i.e. head/tail/whatever-you-name-the-middle).

I think we can further improve the experience of interacting with a number box by selecting the entire number when clicking on them, instead of requiring the user to drag? @peppy thoughts?

@bdach
Copy link
Collaborator

bdach commented Jul 4, 2024

I think we can further improve the experience of interacting with a number box by selecting the entire number when clicking on them, instead of requiring the user to drag?

What does that have to do with the issue? The video shows the user selecting the entirety of the text, but some of their input is apparently getting eaten? That sounds like the bigger issue to me here.

@peppy
Copy link
Member

peppy commented Jul 5, 2024

I do agree the content should be selected for both of the textboxes in this popup.

I don't have a mouse connected to test with, but it looks like this may be a bug from typing while a drag operation has not yet finished on the textbox? If possible we'd want to be cancelling the drag operation as soon as the user types anything.

@frenzibyte
Copy link
Member

I don't have a mouse connected to test with, but it looks like this may be a bug from typing while a drag operation has not yet finished on the textbox? If possible we'd want to be cancelling the drag operation as soon as the user types anything.

That does indeed seem to be the underlying cause of the issue. Couldn't notice it out immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants