Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select all text when focusing sample bank/volume textboxes in editor (and number boxes in general) #28805

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

frenzibyte
Copy link
Member

@frenzibyte frenzibyte commented Jul 10, 2024

Coming from #28713 (see second part of #28713 (comment) & #28713 (comment)). This improves the experience of modifying sample bank/volume of each object on the go.

CleanShot.2024-07-10.at.15.21.51.mp4

smoogipoo
smoogipoo previously approved these changes Jul 11, 2024
Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to think of this as an anti-pattern, but maybe it's alright. Requesting a second review.

@peppy
Copy link
Sponsor Member

peppy commented Jul 11, 2024

In my experience, some apps do this and others don't, and some do it in only some places rather than everywhere.

But I can agree that this is in general – once the user is aware of what is going on – a usability and efficiency improvement.

Willing to ship and see what feedback is.

@peppy peppy merged commit c139478 into ppy:master Jul 11, 2024
7 of 11 checks passed
@frenzibyte frenzibyte deleted the select-all-on-focus branch July 11, 2024 08:36
@aL1NaZ4R
Copy link

Volume textbox doesn't do this.

@frenzibyte
Copy link
Member Author

Open an issue thread

@ppy ppy locked and limited conversation to collaborators Jul 22, 2024
@ppy ppy unlocked this conversation Jul 22, 2024
@peppy
Copy link
Sponsor Member

peppy commented Jul 22, 2024

Volume textbox doesn't do this.

It does in the video, and does for me locally. Please make sure you're on the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants