Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when adding mania notes right after changing timing point #28938

Closed
gresial101 opened this issue Jul 19, 2024 · 1 comment · Fixed by #28944
Closed

Crash when adding mania notes right after changing timing point #28938

gresial101 opened this issue Jul 19, 2024 · 1 comment · Fixed by #28944

Comments

@gresial101
Copy link

Type

Crash to desktop

Bug description

It happens if you try to chart right after editing a bpm point or inherit point in the timing menu. i cant say if it happens on any other game mode besides mania editor. Before the most recent update it would give you a warning that something was going wrong and that it automaticly got reported to the devs but now it just straight up crashes which is far more annoying so i feel the need to report this. i have to assume the issue has to do with placeing objects after the divisor lines change distance from the new timing point or inherit point. either way its super annoying that Osu! lazer crashes like this.

Screenshots or videos

osu_2024-07-18_19-46-14

Version

2024.718.0

Logs

compressed-logs.zip

@frenzibyte
Copy link
Member

frenzibyte commented Jul 19, 2024

Relevant log excerpt:

2024-07-19 00:46:12 [error]: An unhandled error has occurred.
2024-07-19 00:46:12 [error]: System.NullReferenceException: Object reference not set to an instance of an object.
2024-07-19 00:46:12 [error]: at osu.Game.Rulesets.Edit.PlacementBlueprint.UpdateTimeAndPosition(SnapResult result)
2024-07-19 00:46:12 [error]: at osu.Game.Rulesets.Mania.Edit.Blueprints.NotePlacementBlueprint.UpdateTimeAndPosition(SnapResult result)
2024-07-19 00:46:12 [error]: at osu.Game.Screens.Edit.Compose.Components.ComposeBlueprintContainer.updatePlacementPosition()
2024-07-19 00:46:12 [error]: at osu.Game.Screens.Edit.Compose.Components.ComposeBlueprintContainer.ensurePlacementCreated()
2024-07-19 00:46:12 [error]: at osu.Game.Screens.Edit.Compose.Components.ComposeBlueprintContainer.refreshTool()
2024-07-19 00:46:12 [error]: at osu.Game.Screens.Edit.Compose.Components.ComposeBlueprintContainer.hitObjectAdded(HitObject obj)

Reproduced on a debug build:

[runtime] 2024-07-19 02:02:11 [error]: An unhandled error has occurred.
[runtime] 2024-07-19 02:02:11 [error]: System.NullReferenceException: Object reference not set to an instance of an object.
[runtime] 2024-07-19 02:02:11 [error]: at osu.Game.Rulesets.Edit.PlacementBlueprint.getPreviousHitObject() in /Users/salman/Projects/osu/osu.Game/Rulesets/Edit/PlacementBlueprint.cs:line 53
[runtime] 2024-07-19 02:02:11 [error]: at osu.Game.Rulesets.Edit.PlacementBlueprint.UpdateTimeAndPosition(SnapResult result) in /Users/salman/Projects/osu/osu.Game/Rulesets/Edit/PlacementBlueprint.cs:line 159
[runtime] 2024-07-19 02:02:11 [error]: at osu.Game.Rulesets.Mania.Edit.Blueprints.ManiaPlacementBlueprint`1.UpdateTimeAndPosition(SnapResult result) in /Users/salman/Projects/osu/osu.Game.Rulesets.Mania/Edit/Blueprints/ManiaPlacementBlueprint.cs:line 58
[runtime] 2024-07-19 02:02:11 [error]: at osu.Game.Rulesets.Mania.Edit.Blueprints.NotePlacementBlueprint.UpdateTimeAndPosition(SnapResult result) in /Users/salman/Projects/osu/osu.Game.Rulesets.Mania/Edit/Blueprints/NotePlacementBlueprint.cs:line 27

@frenzibyte frenzibyte changed the title Osu! lazer editor crash issue. Crash when adding mania notes right after changing timing point Jul 19, 2024
@bdach bdach self-assigned this Jul 19, 2024
@peppy peppy closed this as completed in 4dd225f Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants