Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor timestamp jump does not handle full mods #29146

Closed
kadambishreyas opened this issue Jul 27, 2024 · 0 comments · Fixed by #29172
Closed

Editor timestamp jump does not handle full mods #29146

kadambishreyas opened this issue Jul 27, 2024 · 0 comments · Fixed by #29172

Comments

@kadambishreyas
Copy link
Contributor

kadambishreyas commented Jul 27, 2024

Type

Game behaviour

Bug description

@bdach this pertains to the timestamp jump feature added in #28511.

context:
the most common use case for this feature by mappers is to view a selection of objects from outside web.
typically this means navigating the editor to & selecting a specific pattern while modding over discord.

the typical format of a mod looks like <timestamp> (<object list>) - <any text content>.

problems:

  • the current implementation merged into lazer does not handle pasting a full mod (as many do for convenience when using discord or other plaintext).
  • it also does not handle the trailing - after the object list of a timestamp, which is traditionally treated as a part of the timestamp.
    • notably, this means that lazer cannot parse the timestamp format that it produces itself when copying objects (as demonstrated in the video, where parsing only succeeds after trimming to <timestamp> (<object list>)).

relevant regex:

private static readonly Regex time_regex_lenient = new Regex(@"^(((?<minutes>\d{1,3}):(?<seconds>([0-5]?\d))([:.](?<milliseconds>\d{0,3}))?)(?<selection>\s\([^)]+\))?)$", RegexOptions.Compiled);

Screenshots or videos

Screen.Recording.2024-07-27.at.2.45.55.PM.mp4

Version

2024.727.0-lazer

Logs

compressed-logs.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants