Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to jump to a specific timestamp via bottom bar in editor #28511

Merged
merged 10 commits into from
Jul 3, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Jun 17, 2024

Apparently this is a stable feature and is helpful for modding / dealing with timestamps outside of web.

2024-06-17.17-08-48.mp4

Apparently this is a stable feature and is helpful for modding.
@OliBomby
Copy link
Contributor

OliBomby commented Jun 18, 2024

To match stable there should be a few changes:

  • Timestamps with selected objects should be allowed as input and select the referenced object in the editor. e.g. 10:44:721 (1) - selects object with combo number 1 at the specified time.
  • The time and selection in the editor should update on change of the textbox instead of on commit.
  • Incomplete timestamps should be allowed. e.g. 10:44 goes to 10 minutes 44 seconds.

@bdach
Copy link
Collaborator Author

bdach commented Jun 18, 2024

  • Timestamps with selected objects should be allowed as input and select the referenced object in the editor. e.g. 10:44:721 (1) - selects object with combo number 1 at the specified time.

  • The time and selection in the editor should update on change of the textbox instead of on commit.

  • Incomplete timestamps should be allowed. e.g. 10:44 goes to 10 minutes 44 seconds.

I've made this work although I'm not completely sold on the third thing being a thing. stable's timestamp parsing is very ad-hoc and hand-rolled so I did my own variant of it without looking at stable source because just glancing at it I don't trust it to be very robust or well-defined.

@OliBomby
Copy link
Contributor

I've made this work although I'm not completely sold on the third thing being a thing. stable's timestamp parsing is very ad-hoc and hand-rolled so I did my own variant of it without looking at stable source because just glancing at it I don't trust it to be very robust or well-defined.

I think your time stamp parser behaviour is pretty good. However I forgot to mention one case in stable which is important to have: If you input a single integer, e.g. 6000, without : it should get interpreted as a total milisecond value. This is useful because such time representations often get used internally or in external tools.
Once you implement that, I think its perfect.

@bdach bdach self-assigned this Jun 19, 2024
@peppy peppy self-requested a review July 3, 2024 08:48
@peppy peppy merged commit 5c25555 into ppy:master Jul 3, 2024
15 of 17 checks passed
@bdach bdach deleted the navigate-to-timestamp branch July 3, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants