Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save and reload truncates all hit object coordinates #29340

Closed
OliBomby opened this issue Aug 7, 2024 · 1 comment · Fixed by #29362
Closed

Save and reload truncates all hit object coordinates #29340

OliBomby opened this issue Aug 7, 2024 · 1 comment · Fixed by #29362

Comments

@OliBomby
Copy link
Contributor

OliBomby commented Aug 7, 2024

Type

Game behaviour

Bug description

Saving and reloading a beatmap in the osu! standard editor truncates all decimal object coordinates. This behaviour matches stable but for beatmaps fully made in lazer its preferrable to preserve decimal precision. I suppose this was previously implemented for compatbility with stable but since the addition of the compatibility export feature its no longer necessary to do truncation in the beatmap encoding.
The legacy beatmap decoder should still truncate coordinates for beatmaps below file format V128 for compatibility, but skip truncation for V128 beatmaps.

Screenshots or videos

osu._4dr6a2oOaJ.mp4

Version

2024.731.0-lazer

Logs

compressed-logs.zip

@smoogipoo
Copy link
Contributor

smoogipoo commented Aug 8, 2024

I don't see anything in the encoder doing this, so I think this might be just because of the decoder:

Vector2 pos = new Vector2((int)Parsing.ParseFloat(split[0], Parsing.MAX_COORDINATE_VALUE), (int)Parsing.ParseFloat(split[1], Parsing.MAX_COORDINATE_VALUE));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants