Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken star rating on Random mod #30021

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Sep 27, 2024

  • Pending diffcalc sheet generation & inspection of results

RFC. Closes #29729.

PRing as draft to run sheets first. Passes tests locally though, for better or for worse.

Diff slightly adjusted from what was in the thread to avoid linq allocs.

@bdach
Copy link
Collaborator Author

bdach commented Sep 27, 2024

To examine the effects of this change relative to master:

!diffcalc

@bdach
Copy link
Collaborator Author

bdach commented Sep 27, 2024

To compare against the last known-good revision:

!diffcalc
OSU_A=e6c0056

I believe there have been no meaningful diffcalc changes since then, so in theory this sheet should be empty.

Copy link

github-actions bot commented Sep 27, 2024

Copy link

github-actions bot commented Sep 27, 2024

@MaxOhn MaxOhn mentioned this pull request Sep 27, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random mod - broken difficulty calculation
1 participant