Fix broken star rating on Random mod #30021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To examine the effects of this change relative to master: !diffcalc |
|
To compare against the last known-good revision: !diffcalc I believe there have been no meaningful diffcalc changes since then, so in theory this sheet should be empty. |
|
Well, empty sheets is good, so undrafting... |
smoogipoo
approved these changes
Oct 5, 2024
bdach
added a commit
to bdach/osu
that referenced
this pull request
Oct 14, 2024
As touched on in ppy#30237 (comment), these types of maneouvers are no longer required after ppy#30021 - although as it turns out on closer inspection, these things being there still *did not actually break anything*, because the `slider.Path` mutation at the end of `modifySlider()` causes `updateNestedPositions()` to be called eventually anyway. So this is at mostly a code quality upgrade.
bdach
added a commit
to bdach/osu
that referenced
this pull request
Oct 14, 2024
As touched on in ppy#30237 (comment), these types of maneouvers are no longer required after ppy#30021 - although as it turns out on closer inspection, these things being there still *did not actually break anything*, because the `slider.Path` mutation at the end of `modifySlider()` causes `updateNestedPositions()` to be called eventually anyway. So this is at mostly a code quality upgrade.
bdach
added a commit
to bdach/osu
that referenced
this pull request
Oct 14, 2024
As touched on in ppy#30237 (comment), these types of maneouvers are no longer required after ppy#30021 - although as it turns out on closer inspection, these things being there still *did not actually break anything*, because the `slider.Path` mutation at the end of `modifySlider()` causes `updateNestedPositions()` to be called eventually anyway. So this is at mostly a code quality upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC. Closes #29729.
PRing as draft to run sheets first. Passes tests locally though, for better or for worse.
Diff slightly adjusted from what was in the thread to avoid linq allocs.