Fix slider ticks and repeats incorrectly moved to position of head when strict tracking and any conversion mod that moves objects is active #30281
+71
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes ppy#30237. This is the root failure in the issue, and one that *only* presents when another conversion mod that repositions the objects is also active. That makes the `PathProgress` of the nesteds to be zero, therefore making them occupy the position of the slider head after any mutation to the path.
As touched on in ppy#30237 (comment), these types of maneouvers are no longer required after ppy#30021 - although as it turns out on closer inspection, these things being there still *did not actually break anything*, because the `slider.Path` mutation at the end of `modifySlider()` causes `updateNestedPositions()` to be called eventually anyway. So this is at mostly a code quality upgrade.
bdach
added
ruleset/osu!
area:mods
next release
smoogipoo
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix strict tracking mod not populating path progress for ticks/repeats
Closes #30237.
This is the root failure causing the issue, and one that only presents when another conversion mod that repositions the objects is also active. The failure to populate
PathProgresscorrectly makes thePathProgressof the nested ticks and repeats to be zero, therefore making them occupy the position of the slider head after any mutation to the path.Remove no longer required nested object reposition hacks
As touched on in #30237 (comment), these types of maneouvers are no longer required after #30021 - although as it turns out on closer inspection, these things being there still did not actually break anything, because the
slider.Pathmutation at the end ofmodifySlider()causesupdateNestedPositions()to be called eventually anyway. So this is at mostly a code quality upgrade.