Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement lyrics/subtitles #6565

Closed
smileyhead opened this issue Oct 21, 2019 · 9 comments
Closed

Implement lyrics/subtitles #6565

smileyhead opened this issue Oct 21, 2019 · 9 comments

Comments

@smileyhead
Copy link

Describe the new feature: This is technically already possible with storyboards, but it would look nicer, and be more versatile and user-friendly this way. It would draw above background dim and support multiple languages.
You should probably also be able to enable and disable lyrics, and set your preferred language in settings and the pre-map quick settings.

Proposal designs of the feature:
image
image

@bdach bdach added the proposal label Oct 21, 2019
@bdach
Copy link
Collaborator

bdach commented Oct 21, 2019

Seems awfully large in scope for a relatively small payoff. I'm not sure I would ever care about lyrics during gameplay.

This custom ruleset could be related/interesting, however.

@frenzibyte
Copy link
Member

I honestly upvote this as a new storyboard element or similar.

@smileyhead
Copy link
Author

Seems awfully large in scope for a relatively small payoff.

There are already people who make lyrics via storyboards and that requires much more time and effort. This would make implementing lyrics much simpler and accessible. I'm willing to bet there would be more maps with lyrics, too.

@bdach
Copy link
Collaborator

bdach commented Oct 21, 2019

There are already people who make lyrics via storyboards and that requires much more time and effort. This would make implementing lyrics much simpler and accessible. I'm willing to bet there would be more maps with lyrics, too.

Fair enough, but:

  • Just putting the lyrics down as a UI element as in your design takes away artistic license for the storyboard makers (positioning, typography...)
  • This would really require a non-trivial amount of effort if this was to be implemented entirely within lazer, especially with the scope you've set down in the proposal (ie. in-editor synchronisation, translations).

Internationalisation in general is never easy, so caution has to be exercised. I'm not saying this is straight out unworkable, but at the current time I can't imagine it being anything but very low priority.

@revelsix
Copy link
Contributor

A simpler form of this idea is just having the ability to add text to storyboards (along with custom fonts / colors) without having to add a png of every letter you want to use, which is especially frustrating for Japanese

@peppy
Copy link
Member

peppy commented Oct 22, 2019

Not sure about this one. Probably best to leave it to storyboards as a creative option, or the karaoke ruleset as a required feature.

@andy840119
Copy link
Contributor

Wait

@smileyhead
Copy link
Author

Wait

Hmm?

@andy840119
Copy link
Contributor

I have no idea about this because it seems OK
But the text are too small, and not easy to see while playing.
.
(Or can use my ruleset to create karaoke beatmap.)

@peppy peppy closed this as completed May 27, 2021
@ppy ppy locked and limited conversation to collaborators May 27, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants