Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the displayed BPM at song select with rate adjust mods #11900

Merged
merged 9 commits into from
Feb 25, 2021

Conversation

peppy
Copy link
Member

@peppy peppy commented Feb 25, 2021

This only covers constant rate rate adjust mods. Mods like wind up/wind down will need a more complex implementation which we haven't really planned yet.

Addresses a portion of #10580.

20210225.172548.dotnet.mp4

This only covers constant rate rate adjust mods. Mods like wind up/wind
down will need a more complex implementation which we haven't really
planned yet.
@pull-request-size pull-request-size bot added size/L and removed size/S labels Feb 25, 2021
@smoogipoo
Copy link
Contributor

smoogipoo commented Feb 25, 2021

I've moved the bind of ruleset.ValueChanged back into BDL. This is still pretty incorrect simply because we're on an async context, but I feel safer this way for the time being to not inadvertently break anything.

Something to keep in mind when fixing this class is that every change of beatmap + enter of song select will cause two wedges to load - one via the synchronous execution of setting Beatmap, and another via the callback from the difficulty bindable.

No doubt this is contributing to some stutters/LCA overheads as this causes a beatmap conversion.

smoogipoo
smoogipoo previously approved these changes Feb 25, 2021
@smoogipoo
Copy link
Contributor

I'm done with this branch, leaving the merge to you @peppy / @bdach

@peppy
Copy link
Member Author

peppy commented Feb 25, 2021

@smoogipoo are you saying that it was always loading two wedges?

@smoogipoo
Copy link
Contributor

Yes, that's been the case since the dynamic SR stuff it seems.

@peppy peppy merged commit a792c3f into ppy:master Feb 25, 2021
@peppy peppy deleted the update-bpm-with-mods branch February 26, 2021 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants