-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the displayed BPM at song select with rate adjust mods #11900
Conversation
This only covers constant rate rate adjust mods. Mods like wind up/wind down will need a more complex implementation which we haven't really planned yet.
I've moved the bind of Something to keep in mind when fixing this class is that every change of beatmap + enter of song select will cause two wedges to load - one via the synchronous execution of setting No doubt this is contributing to some stutters/LCA overheads as this causes a beatmap conversion. |
@smoogipoo are you saying that it was always loading two wedges? |
Yes, that's been the case since the dynamic SR stuff it seems. |
This only covers constant rate rate adjust mods. Mods like wind up/wind down will need a more complex implementation which we haven't really planned yet.
Addresses a portion of #10580.
20210225.172548.dotnet.mp4