Remove difficulty spike nerf from the Flashlight skill in osu! #18791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fill out the OP with a description of what this change does / why / any discussions which led to it. As it stands I have no idea what I'm looking at. |
bdach
reviewed
Jun 21, 2022
| @@ -28,6 +28,7 @@ public Flashlight(Mod[] mods) | |||
| private double skillMultiplier => 0.05; | |||
| private double strainDecayBase => 0.15; | |||
| protected override double DecayWeight => 1.0; | |||
| protected override int ReducedSectionCount => -1; | |||
There was a problem hiding this comment.
On the code side -1 is really weird as well as 0 should work the same and actually makes semantic sense.
|
Why not just use |
|
EDIT: Followed up on Discord in pp dev and confirmed this would be a fine direction |
stanriders
previously approved these changes
Jun 22, 2022
|
SR/PP changes sheet in PR description. |
MBmasher
previously approved these changes
Jun 27, 2022
smoogipoo
approved these changes
Jun 29, 2022
This was referenced Jun 29, 2022
This was referenced Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OsuStrainSkill, by default, reduces the highest strains in the final list of strains for a map. The idea behind doing so is that the highest strains will decrease their influence on the overall difficulty of the map. The reason this doesn't make sense for the flashlight skill is because it is memory-based instead of mechanics-based. For example, having only a few "hard-to-memorise" patterns in a map doesn't make it trivial to memorise - the difficulty to memorise those patterns still exists in it's fullest.All in all, the values shouldn't vary by a whole lot by this, but this is in theory more accurate.
The legendary discussion that took place was me spotting that Flashlight nerfs difficulty spikes, and me asking MBMasher (who developed the Flashlight skill) whether they also thought it made no sense. This can be seen here, in the pp dev discord.
SR/PP changes spreadsheet: https://docs.google.com/spreadsheets/d/1RGtONEOfAgBE6WX-htrJTzxr5w_B2aCqZA8eM7iGL6o/edit?usp=sharing
As of 630bd24