Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osu! performance points balancing pass #19001

Merged
merged 20 commits into from
Aug 11, 2022
Merged

Conversation

stanriders
Copy link
Member

@stanriders stanriders commented Jul 4, 2022

Changes included here:

  1. Slightly raw aim buff (which does not include slider aim or high bpm aim)
  2. Add OD multipliers to ok/meh miss additions for relax (https://www.desmos.com/calculator/bc9eybdthb), remove ar bonus and reduce flashlight pp for relax (replaces More implementations for Relax (pp and star rating) #16708)
  3. Reduce speed 50s nerf (would love to remove it completely eventually, but for now just https://www.desmos.com/calculator/axwv6i9hrs)
  4. Reduce low AR bonus because some maps were getting more pp with easy mode than without it (i.e https://osu.ppy.sh/beatmapsets/149471 +HTEZ being 391pp vs +HT being 379pp)

SR/PP changes sheet: https://docs.google.com/spreadsheets/d/1M26JmN76yLo9H8MxDrlNz0Aeh2p4BhaT6Mnt4gux7IU/edit

As of 760742e

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 4, 2022
@stanriders stanriders changed the title osu performance points balancing pass osu! performance points balancing pass Jul 4, 2022
emu1337
emu1337 previously approved these changes Jul 4, 2022
Copy link
Member

@emu1337 emu1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Global aim multiplier doesn't seem necessary but doesn't break anything either.

@stanriders stanriders requested a review from a team July 12, 2022 20:47
@smoogipoo
Copy link
Contributor

SR/PP sheet added to description. Awaiting 2 approvals before merge.

emu1337
emu1337 previously approved these changes Jul 14, 2022
Copy link
Contributor

@apollo-dw apollo-dw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to unapprove in light of player satisfaction, I think we should consider looking into increasing the PP multiplier and this is a good PR to do it on

@apollo-dw
Copy link
Contributor

As per frost's comment in pp-dev, the cube root term in the total SR formula needs to be updated to reflect any changes to the global pp multiplier. Making the multiplier static and using it instead of updating it everytime (and potentially forgetting to) sounds like the right course of action to me.

double starRating = basePerformance > 0.00001 ? Math.Cbrt(1.12) * 0.027 * (Math.Cbrt(100000 / Math.Pow(2, 1 / 1.1) * basePerformance) + 4) : 0;

Copy link
Contributor

@apollo-dw apollo-dw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above

@stanriders stanriders requested a review from a team July 20, 2022 13:11
emu1337
emu1337 previously approved these changes Jul 20, 2022
apollo-dw
apollo-dw previously approved these changes Jul 21, 2022
@smoogipoo smoogipoo dismissed stale reviews from apollo-dw and emu1337 via 9f28c4c August 11, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants