Add BeatmapInfo.LastUpdate to track the time of local changes
#19530
Conversation
osu.Game/Beatmaps/BeatmapInfo.cs
Outdated
| /// <summary> | ||
| /// The last time of a local modification (via the editor). | ||
| /// </summary> | ||
| public DateTimeOffset? LastUpdated { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// The last time online metadata was applied to this beatmap. | ||
| /// </summary> | ||
| public DateTimeOffset? LastOnlineUpdate { get; set; } |
There was a problem hiding this comment.
I'm not sure how to feel about having both DateTimeOffset? BeatmapInfo.LastUpdated (added here) and DateTimeOffset? BeatmapInfo.LastOnlineUpdate (already present). Can we rename the former to something like LastLocalUpdate or something for clarity?
There was a problem hiding this comment.
Looking back at this, I'm wondering if we can just have a single property to handle both? I can't think of a case where we'd use the online value if there are local modifications. And it would be reset to the correct value the next time an update is applied (restoring to a non-modified state).
There was a problem hiding this comment.
There was a problem hiding this comment.
Yeah, best to keep separate for now. We can complicate things later if required.
I'll rename to LastLocalUpdate for now.
Also fix
DateAddednot being set to a sane value when creating a new beatmap in the editor.Note that this date is not currently used, but I figure it will be useful for showing a user's own creations (which would default to "last modified" for sure).