Remove FrameStableClock (and redirect usages to FrameStabilityContainer)
#19776
Conversation
…lock` is available
| @@ -1,8 +1,6 @@ | |||
| // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence. | |||
| // See the LICENCE file in the repository root for full licence text. | |||
|
|
|||
| #nullable disable | |||
There was a problem hiding this comment.
Enabling NRT in this file seems a bit drive-by (there seem to be no actual changes in this file related to FrameStableClock) but ok.
There was a problem hiding this comment.
I think I originally had changed in this file...
| [BackgroundDependencyLoader] | ||
| private void load(IGameplayClock? gameplayClock) |
There was a problem hiding this comment.
Are we still changing [BackgroundDependencyLoader(true)] to NRT-annotated params after the latest mono-related fiasco? Not that I imagine this particular one will cause issues, but it's a bit touch-and-go and I'm not sure where we're at regarding this.
There was a problem hiding this comment.
I did consider that for this specific usage, but I do believe it's only a problem in tests. Can revert if preferred.
There was a problem hiding this comment.
Should be okay. Honestly would like to see NET6 prioritised still...
GameplayClocktoIGameplayClock#19775.