Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slider ticks playing back at infinite rate while making changes to a slider in the editor #19800

Merged
merged 3 commits into from
Aug 17, 2022

Conversation

peppy
Copy link
Member

@peppy peppy commented Aug 16, 2022

This is the easiest way I could think of fixing this. The good part is that this should also help with any other blueprints across all rulesets that are hitting a similar issue.

Addresses concerns raised in #19714.

@smoogipoo
Copy link
Contributor

Not sure I agree with this arbitrary schedule for something named as generic as UpdateInProgress from a component as global as EditorBeatmap. Maybe that's just me.

Test failure needs attention.

@peppy
Copy link
Member Author

peppy commented Aug 16, 2022

An alternative is to move it to Editor and make the UpdateInProgress just an UpdateInvoked action instead.

@smoogipoo
Copy link
Contributor

That sounds better, but I wouldn't consider it a requirement for this PR unless others agree.

@peppy
Copy link
Member Author

peppy commented Aug 17, 2022

I've moved the debounce flow into Editor instead.

As for the test failure, turns out it is quite important... and relies on the SamplePlaybackDisabled flag being updated via event flow (in this particular case, from OnSuspending during the transition to gameplay, to stop slider track sounds from playing).

I've just restored the original event-based flow for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants