Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add audio feedback for invalid textbox input #20045

Merged
merged 5 commits into from
Aug 31, 2022
Merged

Add audio feedback for invalid textbox input #20045

merged 5 commits into from
Aug 31, 2022

Conversation

nekodex
Copy link
Contributor

@nekodex nekodex commented Aug 31, 2022 •
edited by peppy
Loading

Also refactored the sample playback logic in OsuTextBox a bit.

textbox-error.mov

@nekodex nekodex added the audio label Aug 31, 2022
@nekodex nekodex self-assigned this Aug 31, 2022
@peppy peppy self-requested a review August 31, 2022 13:08
peppy
peppy previously approved these changes Aug 31, 2022
View reviewed changes
@peppy peppy enabled auto-merge August 31, 2022 13:15
@peppy peppy disabled auto-merge August 31, 2022 14:58
@peppy peppy merged commit 3495215 into ppy:master Aug 31, 2022
This was referenced Sep 1, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
This was referenced Sep 5, 2022
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy left review comments

Assignees

@nekodex nekodex

Labels
audio size/L
Projects
osu! development roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nekodex @peppy