Add ability to clone objects in the editor #20901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
previously approved these changes
Oct 24, 2022
bdach
reviewed
Oct 24, 2022
|
I've fixed the issue pointed out and added test coverage. I've also renamed to "Clone" as I think it reads better. |
bdach
approved these changes
Oct 25, 2022
Comment on lines
+41
to
+44
| // Overlay bindings may conflict with more local cases like the editor so they are checked last. | ||
| // It has generally been agreed on that local screens like the editor should have priority, | ||
| // based on such usages potentially requiring a lot more key bindings that may be "shared" with global ones. | ||
| .Concat(OverlayKeyBindings); |
There was a problem hiding this comment.
Here's hoping we have good test coverage and/or this one doesn't wreak too much havoc, because I'm not manually checking every single binding...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of a low-effort implementation, but I'd like to push this out and see what kind of feedback mappers have. The implementation in stable is a bit nuanced, and may be preferred in some cases and potentially not in others. I think stable's behaviour is probably better when the current time is equal to the start time of the pattern being copied, but if the current time point is already in the future, it should work as per this PR's implementation?
One more thing: I'm not sure whether we should call this "clone" or "duplicate" when exposing to the user. I went with "duplicate" to avoid method clashes with
object.Clonebut I think "clone" may be more standard a term to users?To make this work, I have reordered how bindings are handled at a game-wide level. Now, top level overlay bindings are giving less precedence than all local usages. I think this makes more sense (discussed with @smoogipoo and he tends to agree).
Closes #20860.