Implement legacy countdown #21009
Implement legacy countdown #21009
Conversation
|
One of the CI errors are because of the The other two, |
|
|
||
| double offset = Player.GameplayClockContainer.StartTime; | ||
|
|
||
| Scheduler.AddDelayed(() => sampleReady?.Play(), goTime - 5.9 * beatLength - offset); |
There was a problem hiding this comment.
This kind of logic isn't going to work with rewinding (and probably not even with pausing, depending on the scheduler's clock). At very least this needs to use transforms, but that might not be the best way forward.
There was a problem hiding this comment.
Gotcha. Should I try readdressing this with transforms? If so, could you give me some guidance on where to start or point me to somewhere they're used in a similar way in the game?
Closes #20584
Prereqs:
BeatmapInfocorrectly #20883This PR adds the countdown currently only present in stable. It is not visible in osu!taiko and osu!mania, but present in all other rulesets by default if a legacy skin is used.
The countdown from stable and from lazer onion skinned:
countdown.overlay.mp4
User skins:
countdown.skin.mp4
I haven't written any tests for this, so if someone could do that that would be great.
The code is a bit messy since this only adds the legacy countdown and not a "new" lazer-one (for example, it currently assumes that both will use the same timings
CountdownTimings.GetTimings()), but if the rest looks good I'd be willing to add the lazer-countdown as well when a design for it is made.