Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic difficulty & performance calculation for Autopilot mod on osu! ruleset #21211

Merged
merged 8 commits into from
Dec 29, 2024

Conversation

tsunyoku
Copy link
Member

@tsunyoku tsunyoku commented Nov 12, 2022

This PR adds a base for difficulty & performance calculation for the Autopilot mod.

These are the changes:

  • The speed skill will not consider note distance when Autopilot is enabled.
  • Speed difficulty is reduced (50%) to account for speed including more than just tapping skill and the assumed added hand availability.
  • Flashlight difficulty is reduced by 60%.
  • Aim difficulty & performance are completely removed.
  • Approach rate bonuses in speed performance calculation are completely removed.

@stanriders
Copy link
Member

#20693 (comment)

Apart from that, speed should probably be reduced by at least 50% since you can use two hands for tapping

@tsunyoku
Copy link
Member Author

tsunyoku commented Nov 12, 2022

#20693 (comment)

Apart from that, speed should probably be reduced by at least 50% since you can use two hands for tapping

For the comment you linked, I feel that... I noticed this same thing when I add diffcalc for anyh mod.

As for reducing by 50% - unsure. I did some testing with this system before PRing and I think if we reduce by even 50% values will be worth very low overall. And 2 hands? What benefit does this have? It's still 2 keys. I think I can understand reducing it more, but that drastically and for that reason, unsure if I agree.

@stanriders
Copy link
Member

Using 2 hands is quite a lot easier since you can use the whole hand for tapping, as well as switching fingers at any time. 50% might be a bit too big, but if you consider that speed also has distance scaling it sounds okay to me

@tsunyoku
Copy link
Member Author

tsunyoku commented Nov 13, 2022

Using 2 hands is quite a lot easier since you can use the whole hand for tapping, as well as switching fingers at any time. 50% might be a bit too big, but if you consider that speed also has distance scaling it sounds okay to me

I set distance to 0 on speed for this reason (see https://github.com/ppy/osu/pull/21211/files#diff-63100aca8fa85bf402677740e45b3fc1ab11c505357c859740bf591b35cacf98R68). Still an issue?

@smoogipoo smoogipoo changed the base branch from master to pp-dev December 18, 2024 14:09
@tsunyoku tsunyoku marked this pull request as ready for review December 18, 2024 18:16
@stanriders stanriders enabled auto-merge (squash) December 29, 2024 18:50
@stanriders stanriders merged commit 988ed37 into ppy:pp-dev Dec 29, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Pending Deploy
Development

Successfully merging this pull request may close these issues.

4 participants