Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android crash when using non-Gregorian calendars #21583

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

Susko3
Copy link
Member

@Susko3 Susko3 commented Dec 8, 2022

Regressed with #21164. That PR changed the logic to use the system culture, which would try to load System.Globalization.ThaiBuddhistCalendar, but that calendar was removed by the linker.

This PR just adds all the calendars to linker exceptions for both Android and iOS (just in case).

We've had linker issues on Android before: #20872.

@smoogipoo smoogipoo merged commit f2fdff2 into ppy:master Dec 9, 2022
@Susko3 Susko3 deleted the fix-android-linker-calendars branch December 9, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

osu!lazer crashing on Android since version 2022.1101.0
2 participants