Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix beatmap listing sort direction not resetting when changing criteria #22926

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

Joehuu
Copy link
Member

@Joehuu Joehuu commented Mar 21, 2023

To be in line with web behavior.

Before:
osu!_Di9FddkDsd

After:
osu!_hzTEeBoIji

Web:
firefox_7VdvYydzI7

@peppy
Copy link
Member

peppy commented Mar 22, 2023

I feel like the icon on the other buttons should show as a downwards arrow from the outset (ie. showing the state it's going to be in when clicked) rather than updating on click.

@peppy peppy self-requested a review April 3, 2023 06:31
@peppy peppy merged commit 43d7386 into ppy:master Apr 3, 2023
@Joehuu Joehuu deleted the fix-sort-direction-not-resetting branch April 3, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants