Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clamping to SliderMultiplier and SliderTickRate at parsing time #23433

Closed
wants to merge 11 commits into from

Conversation

peppy added 11 commits May 8, 2023 13:13
The intention was to give an idea of what the most common velocity of
the beatmap is, but in hindsight, because the "base" velocity is being
set elsewhere this doesn't make sense. It will/should be 1.0x.

Showing this range is still valuable, though.
I think this makes the most sense of the iterations I've tested so far, albeit maybe being a touch too verbose.
These values are used for more than just sliders across all rulesets, so
it makes sense to rename them as such.
@peppy peppy added area:gameplay and removed size/L labels May 8, 2023
@peppy peppy added the next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! label May 8, 2023
@bdach
Copy link
Collaborator

bdach commented May 9, 2023

This went in as part of #23434 (as ca5e8b2). I'm not sure how intentional that was, but I decided to not care and get that in there since it looked correct anyway, and to just close this to save us all the ceremony.

@bdach bdach closed this May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:gameplay next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants