Refactor IWorkingBeatmap.Background to GetBackground()
#23808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
force-pushed
the
working-beatmap-get-background
branch
from
95882d3
to
a842f79
Compare
peppy
commented
Jun 8, 2023
| @@ -23,8 +23,9 @@ public BeatmapBackgroundSprite(IWorkingBeatmap working) | |||
| [BackgroundDependencyLoader] | |||
| private void load() | |||
| { | |||
| if (working.Background != null) | |||
There was a problem hiding this comment.
This example alone should be enough for anyone to jump on this change. It's actually retrieving two backgrounds (one in the null check).
Merged
1 task
bdach
approved these changes
Jun 8, 2023
Merged
1 task
andy840119
added a commit
to andy840119/karaoke
that referenced
this pull request
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This property has been misleading for a long time (see comment about a new texture being returned each time due to refcounting), so I propose we rename it in line with our standards to avoid any confusion.