Use more correct localised string source for "sign out" text

[peppy]

#24026

[bdach]

Thoughts on making the rest of the dropdown's items match the Title Casing? Could either change the source localisations. Or do

diff --git a/osu.Game/Overlays/Login/UserDropdown.cs b/osu.Game/Overlays/Login/UserDropdown.cs
index f2a12f9a1e..b885a5fc3d 100644
--- a/osu.Game/Overlays/Login/UserDropdown.cs
+++ b/osu.Game/Overlays/Login/UserDropdown.cs
@@ -1,8 +1,10 @@
 // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
 // See the LICENCE file in the repository root for full licence text.
 
+using osu.Framework.Extensions.LocalisationExtensions;
 using osu.Framework.Graphics;
 using osu.Framework.Graphics.UserInterface;
+using osu.Framework.Localisation;
 using osu.Game.Graphics.UserInterface;
 using osu.Game.Users.Drawables;
 using osuTK;
@@ -16,6 +18,11 @@ public partial class UserDropdown : OsuEnumDropdown<UserAction>
 
         protected override DropdownMenu CreateMenu() => new UserDropdownMenu();
 
+        protected override LocalisableString GenerateItemText(UserAction item)
+        {
+            return base.GenerateItemText(item).ToTitle();
+        }
+
         public Color4 StatusColour
         {
             set

I guess.

[peppy]

Yeah I dunno. checking other dropdowns we're all over the place

I'm not sure how well ToTitle will work on other languages, is the plan there to only make it do anything on languages which support it?

[bdach]

I'm not sure how well ToTitle will work on other languages

Fair point, but the other option of changing other localisations to match still stands. We control LoginPanelStrings so we can do this here.

[peppy]

For sure, just not sure if we want title case or not at this point.

[bdach]

I'm... not sure I have a well-formed opinion about that, I'd just probably match the swapped-out string and do title case. @Joehuu might have other opinions?

[Joehuu]

It shouldn't be title-cased as the majority of other cases use sentence-cased (e.g. LoginPanel, UserActivity [still not localised but is sentence-cased], and most dropdown items when you look at it [only saw 3 title-cased, including the one mentioned above]). With the above diff:

I would use ToSentence() just to fix the one case of Sign Out, but that method needs to ToLower() everything first:
https://github.com/ppy/osu-framework/blob/19cbb8f4a681b4e8cb7838127ddcf91b71870cea/osu.Framework/Localisation/CaseTransformableString.cs#L60-L68

[peppy]

At this point we should either fix osu-web side, or duplicate the string.

[bdach]

I'd say duplicate.