Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make results / statistics visual testing easier with better data population #24203

Merged
merged 7 commits into from
Jul 13, 2023
Merged

Make results / statistics visual testing easier with better data population #24203

merged 7 commits into from
Jul 13, 2023

Commits on Jul 13, 2023

  1. Change order and test population in TestSceneStatisticsPanel to giv… 

    …e better visible results
    @peppy
    peppy committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    6529c81 View commit details
    Browse the repository at this point in the history

  2. Add full statistics score to TestSceneResultsScreen

    @peppy
    peppy committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    b7ab46d View commit details
    Browse the repository at this point in the history

  3. Show online stats on TestSceneStatisticsPanel 

    Fix test regression
    @peppy
    peppy committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    aebbffa View commit details
    Browse the repository at this point in the history

  4. Add actual statistics changes to better visualise layout

    @peppy
    peppy committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    654a705 View commit details
    Browse the repository at this point in the history

  5. Reorder tests for testability

    @peppy
    peppy committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    6ef39b8 View commit details
    Browse the repository at this point in the history

  6. Crudely fix crashes when switching between TestResultsWithPlayer cases 

    In the visual test browser, if two `TestResultsWithPlayer` test cases
are ran consecutively, the second would die on `SoloStatisticsWatcher`
seeing duplicated online score IDs. This surfaced after
6ef39b8, which changed
`TestResultsScreen` to inherit `SoloResultsScreen` rather than
`ResultsScreen`.

This is probably _not_ a very good fix, but I'm trying to be pragmatic
for now. `SoloStatisticsWatcher` should probably not live in
`OsuGameBase`.
    @bdach
    bdach committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    4b06b6f View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into results-screen-testability

    @bdach
    bdach committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    56409fa View commit details
    Browse the repository at this point in the history