Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to toggle all free mods quickly at multiplayer song select #24294

Merged
merged 4 commits into from
Jul 20, 2023

Conversation

peppy
Copy link
Member

@peppy peppy commented Jul 19, 2023

Addresses concerns in #23560.

osu.2023-07-19.at.10.09.35.mp4

@Haspamelodica
Copy link
Contributor

Haspamelodica commented Jul 19, 2023

Suggestion: Maybe change "Off" and "On" to "None" and "All"?
Off/On has the advantage of being very intuitive for new users, especially users coming from stable, but None/All describes better what is actually happening and hints at the possibility of selecting specifc mods. I'm not sure which is better here.

@peppy
Copy link
Member Author

peppy commented Jul 20, 2023

Suggestion: Maybe change "Off" and "On" to "None" and "All"?
Off/On has the advantage of being very intuitive for new users, especially users coming from stable, but None/All describes better what is actually happening and hints at the possibility of selecting specifc mods. I'm not sure which is better here.

I dunno, I specifically chose "off" and "all" (not what you said here, so maybe you misread?) for ability to understand it.

@Haspamelodica
Copy link
Contributor

I dunno, I specifically chose "off" and "all" (not what you said here, so maybe you misread?) for ability to understand it.

Whoops, yes, I just misread, sorry

@bdach bdach merged commit c77d3cd into ppy:master Jul 20, 2023
@peppy peppy deleted the toggle-all-freemods branch July 29, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants