Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce spacing in settings items #24314

Merged
merged 1 commit into from
Jul 22, 2023
Merged

Reduce spacing in settings items #24314

merged 1 commit into from
Jul 22, 2023

Conversation

peppy
Copy link
Member

@peppy peppy commented Jul 21, 2023

Felt like too much, maybe? Looking for more opinions.

Before After
osu! 2021-09 at 06 38 55 osu! 2023-07-21 at 06 39 23

@novialriptide
Copy link
Contributor

I like it.

@Glinte
Copy link

Glinte commented Jul 21, 2023

The spacing between "Output device" and the dropdown box feels better before

@agatemosu
Copy link

agatemosu commented Jul 21, 2023 •
edited
Loading

It looks better, except the box

bdach
bdach approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, doesn't look much better or worse as far as I'm concerned, so I'm fine with going with it. Dunno if this is enough opinions for you already.

Joehuu
Joehuu approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@Joehuu Joehuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems better. The before and after images are swapped, so not sure how correct the other opinions are.

@bdach
Copy link
Collaborator

bdach commented Jul 21, 2023

so not sure how correct the other opinions are

If you're asking me, then I read the diff and checked out the code myself. So I know what I approved.

@bdach bdach merged commit 7e61a10 into ppy:master Jul 22, 2023
@peppy peppy deleted the reduce-settings-item-spacing branch July 29, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joehuu Joehuu Joehuu approved these changes

@bdach bdach bdach approved these changes

Assignees
No one assigned
Labels
area:settings size/XS type:cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@peppy @novialriptide @Glinte @agatemosu @bdach @Joehuu