Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At COE, it was brought up to me that this map wasn't loading: https://osu.ppy.sh/beatmapsets/501530#mania/1073952 Turns out that it is loading, just very slowly.
The primary reason is that it creates some 200k drawables, which this PR directly addresses. The implementation here is similar to the taiko one.
The second reason, which is not addressed in this PR, and likely doesn't need to be addressed, appears to be some inefficiency in HitObjectContainer resulting in what looks to be worst case sort complexity:
i.e. every object added to the HOC causes the HOC to immediately be re-sorted:
osu/osu.Game/Rulesets/UI/HitObjectContainer.cs
Lines 153 to 164 in 01eceea