Apply NRT to osu.Game.Beatmaps.Formats namespace
#24568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
changed the title
osu.Game.Betamaps.Formats namespaceosu.Game.Beatmaps.Formats namespace
bdach
approved these changes
Aug 21, 2023
| @@ -13,7 +11,7 @@ public interface IHasComboColours | |||
| /// <summary> | |||
| /// Retrieves the list of combo colours for presentation only. | |||
| /// </summary> | |||
| IReadOnlyList<Color4> ComboColours { get; } | |||
| IReadOnlyList<Color4>? ComboColours { get; } | |||
There was a problem hiding this comment.
This one's kinda painful, but can't be easily eliminated, so I'm looking away for the time being...
The long term answer to this is probably interface separation or something like that.
There was a problem hiding this comment.
Yeah, right now it's there with reason so I didn't touch it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just applied in passing.