Fix hit circles fading out too fast when hit with classic mod active #24686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added automated testing for this, since it was quite easy to do. Haven't compared to stable but the code looks fine. |
peppy
approved these changes
Aug 31, 2023
bdach
changed the title
DrawableHitCircle animation while in hit state
|
Video comparisons vs stable: Test map 1 (taken from issue thread)about_you.mp4Test map 2Call this one a regression test for #22543 (I made it based off the description of that PR, OD0 simultaneous slider & hitcircle) hit_circle_fade.mp4I'm gonna call that good enough and not spend too much more time on it... |
bdach
approved these changes
Aug 31, 2023
bdach
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The animation applied in
ModClassicshould be specific to when a player misses the hit circle. Right now the animation applies regardless of the circle's state.For anyone expecting a video showcasing the difference between master and PR in here, I haven't set up any tools for that yet. I'll figure it out if I have enough time.