Tidy up LegacyLastTickOffset usages and stop passing everywhere

[peppy]

Initial code quality / cleanup pass for #22805, before making any logic changes to this.

There should be no behavioural changes as a result of this change.

[bdach]

For all intents and purposes I don't see this changing anything but may run a sheet for this one anyways just to be on the safe side.

[peppy]

For all intents and purposes I don't see this changing anything but may run a sheet for this one anyways just to be on the safe side.

If we must, then I'd run it against #24966 instead and hold off merging this until confirmed. But I don't see how this could affect difficulty calculation.

[bdach]

Sure, I can do that instead. Generally want to rack @smoogipoo's brain on this one anyways after the last time we did a "legacy" prefix removal on a thing.

[smoogipoo]

I'm running a diffcalc test on this right now at https://github.com/smoogipoo/ga-diffcalc-tester/actions/runs/6380004379, though I don't know if it'll complete successfully at the moment 😅

[peppy]

I'm running a diffcalc test on this right now at smoogipoo/ga-diffcalc-tester/actions/runs/6376069767, though I don't know if it'll complete successfully at the moment 😅

Did you see #24965 (comment)? Not sure on the value of running on this PR, but I guess it's fine.

[smoogipoo]

Yeah I’m running it on the follow up PR, but posted here to be relevant for the above comment.

[smoogipoo]

This is fine to get in on its own.