Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extended info support to tiny mod switches #25093

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

Joehuu
Copy link
Member

@Joehuu Joehuu commented Oct 11, 2023

Mostly copied from ModIcon, but:

  • ModSwitchTiny.Mod is immutable so kept it that way
  • showExtendedInformation defaults to false as current usages don't need it
  • little tweak to font size
Screen.Recording.2023-10-11.at.12.53.37.PM.mov

@Tanza3D
Copy link

Tanza3D commented Oct 12, 2023

thought i'd drop my thoughts on this - text colour's a little off from the switches but im guessing that's intentional. design looks good

@peppy peppy self-requested a review October 13, 2023 04:37
Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to do the job

@peppy peppy merged commit aabed8b into ppy:master Oct 13, 2023
@Joehuu Joehuu deleted the mod-switch-tiny-extended-info branch October 13, 2023 04:42
@Loreos7
Copy link
Contributor

Loreos7 commented Oct 13, 2023

I'm against such a design of mod icons, because it is impossible to understand from the abbreviations at a glance which mods were applied to the score. It is much easier to distinguish records by unique icons.

@peppy
Copy link
Member

peppy commented Oct 13, 2023

All well and good, but these are already used all over the place. You're better off opening a discussion separate from this PR, which is doing not much more than adding support for multipliers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants