Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change spinner score display to show when reaching max bonus score #25177

Merged
merged 5 commits into from
Oct 21, 2023
Merged

Change spinner score display to show when reaching max bonus score #25177

merged 5 commits into from
Oct 21, 2023

Conversation

peppy
Copy link
Member

@peppy peppy commented Oct 20, 2023 •
edited
Loading

Just a quick / best effort implementation. Might adjust animations in the future.

Addresses #25172.

CleanShot.2023-10-20.at.07.11.47.mp4

@peppy
Copy link
Member Author

peppy commented Oct 20, 2023

@nekodex might be worth adding a special sound after hitting the bonus? A minor variant on the standard bonus sound?

@peppy peppy added the next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! label Oct 20, 2023
@nagi-desuuu
Copy link

nagi-desuuu commented Oct 20, 2023 •
edited
Loading

What would happen for legacy skins, though? Is it still going to use old behavior?
The sounds, I mean.

@bdach bdach self-requested a review October 20, 2023 19:44
bdach
bdach approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is here so far looks good.

I'm not sure to me if the request for additional sound samples should be interpreted as blocking this or not though.

@peppy
Copy link
Member Author

peppy commented Oct 21, 2023

Non blocking

@peppy peppy merged commit d059949 into ppy:master Oct 21, 2023
@peppy peppy deleted the spinner-max-display branch October 23, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdach bdach bdach approved these changes

Assignees
No one assigned
Labels
area:gameplay next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! ruleset/osu! size/L type:cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peppy @nagi-desuuu @bdach