Add "Argon" performance points counter #25362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Closing as this is too stale in its current state. I'm better off reworking it off of master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview:
CleanShot.2023-11-05.at.02.31.48.mp4
Notes:
The PP counter should probably be set to fixed-width, but I've kept it as-is to match design, leaving it to others for tweaking it.
Similar to the other counters, fixed width should probably be enabled, but I've kept it as is to match reference design.
The font size specifications are intentionally different from the reference designs. To be specific, they're set to 1.2x the reference specifications, to remain visually matching with the designs (see CSS-compatible font sizing osu-framework#3271 & Implement CSS-style font size algorithm osu-framework#5123).