Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ManiaHealthProcessor that uses the legacy drain rate algorithm #25587

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Nov 27, 2023

Similar to #25563

Also contains the fix for the bug with hold notes as a result of using the base LegacyDrainingHealthProcessor implementation.

Small sampling of comparison against the legacy implementation (present inside my osu-tools branch): https://docs.google.com/spreadsheets/d/1FQvCIlhGJqKJ9ssdGFZZOC2cNmq-LGyaVR-smAFRq1k/edit?usp=sharing

@bdach bdach merged commit ee0494a into ppy:master Nov 27, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants