Rework slider judgements to more closely match stable and be more sane #25589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11769
Slider mechanics:
Great / Ok / Meh / Miss
).Great / Miss
, as compared to osu-stable's30 / Miss
, so the raw accuracy value differs.LargeTickHit / LargeTickMiss
.LargeTickHit / LargeTickMiss
.LargeTickHit / IgnoreMiss
(no combo break on miss).LegacyGreatNoCombo / LegacyOkNoCombo / LegacyMehNoCombo
(non-combo-increasing variants ofGreat / Ok / Meh
).Differences between this implementation and the legacy scorev1/scorev2 implementation:
Although all the tests pass, this still needs some rigorous manual testing before merge.