Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework slider judgements to more closely match stable and be more sane #25589

Closed
wants to merge 4 commits into from

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Nov 27, 2023

Resolves #11769

Slider mechanics:

  • Slider head accuracy is maintained (Great / Ok / Meh / Miss).
    • With classic mod, slider heads are limited to Great / Miss, as compared to osu-stable's 30 / Miss, so the raw accuracy value differs.
  • Slider ticks are judged as LargeTickHit / LargeTickMiss.
  • Slider repeats are judged as LargeTickHit / LargeTickMiss.
  • Slider tail (the final tick of the slider) is judged as LargeTickHit / IgnoreMiss (no combo break on miss).
  • The slider itself is judged proportionally to the number of ticks hit, similar to ScoreV1/ScoreV2 in osu!stable.
  • The slider itself is judged with LegacyGreatNoCombo / LegacyOkNoCombo / LegacyMehNoCombo (non-combo-increasing variants of Great / Ok / Meh).

Differences between this implementation and the legacy scorev1/scorev2 implementation:

  • In ScoreV1/ScoreV2, slider heads are worth a maximum of 30 score.
    • In this implementation, it's worth a maximum of 300 score.
  • In ScoreV2, sliders are capped by the judgement of the head. For example, hitting the head in the 50 timing window will award the maximum score for the head (30), but cap the slider's judgement at 50 regardless of how many ticks were hit.
    • In this implementation, only the head's judgement is affected. In the same scenario as above, you'll receive 50 score for the head but 300 score for the slider (assuming you hit all other ticks perfectly).
  • In ScoreV2, missing the head will cap the slider's judgement to 50 and not award any score for the head.
    • In this implementation, you'll miss the head and be capped at 100 score for the slider (the head is itself counted as a tick for the slider's judgement).

Although all the tests pass, this still needs some rigorous manual testing before merge.

@smoogipoo smoogipoo changed the title Rework slider judgements to match stable and be more sane Rework slider judgements to more closely match stable and be more sane Nov 27, 2023
@smoogipoo
Copy link
Contributor Author

Closing PR temporarily as I've noticed an issue in implementation/still discussing mechanics.

@smoogipoo
Copy link
Contributor Author

Closing because this needs more thinking, especially around the classic mod (and if similar -- new hit statistics are also needed for non-classic).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sliders gives combo for slider end when player misses slider end in Classic mod
1 participant