Fix ArgonHealthDisplay not displaying miss correctly during initial transition
#25673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzibyte
force-pushed
the
fix-argon-initial-display
branch
from
a7d1e6a
to
629e64d
Compare
|
I dunno. Both these behaviours should never be visible to an end user because the assumption is that the initial animation will have completed before any hitobjects are able to be judged. |
peppy
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArgonHealthDisplaysometimes behaving weirdly on miss judgements (alternative) #25672Noticed while looking into #25672. Not sure if the new behaviour is more correct, hence why I separated it from the above. @peppy requesting your review for behavioural feedback.
Before:
CleanShot.2023-12-04.at.23.51.44.mp4
After:
CleanShot.2023-12-04.at.23.54.36.mp4