Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JuiceStream velocity calculation #25725

Merged
merged 3 commits into from
Jun 28, 2024

Add test for correct juice stream tick counts in editor

deeb2e9
Select commit
Loading
Failed to load commit list.
Merged

Fix JuiceStream velocity calculation #25725

Add test for correct juice stream tick counts in editor
deeb2e9
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Jun 28, 2024 in 0s

2 / 2 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
Closes #28534 (for the majority case, see #25725 (comment)) Incomplete
Add at least one test case beatmap Completed
Validate results of spreadsheet above Completed
In most cases, the last fruit is later by 1ms, and thus causes a hyperdash that was not there previously. Incomplete
In one case (3091364), the last fruit is earlier by ~0.000002ms, and becomes not-hyper. Incomplete