Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 1-10K mods into a single "Key Count" mod #25796

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

cl8n
Copy link
Member

@cl8n cl8n commented Dec 17, 2023

another attempt at #25505, closes #25252

069053b is my attempt to convert the previous mod acronyms into something useful, but I'm not sure if this is the right way to go about it. and I have not tested this with the full web stack yet but I suspect things will break there...

I am also not confident that my changes to DifficultyAdjustmentMods for the diff calculator are correct, because I haven't checked to see how those are used in other projects yet

@bdach
Copy link
Collaborator

bdach commented Dec 17, 2023

I'll just say that this merging of key mods has infrastructural concerns that will need handling in server side components and probably also web. Thus, I am personally not reviewing it this year as I consider it largely unimportant in the scale of everything.

@cl8n
Copy link
Member Author

cl8n commented Dec 18, 2023

👌 no rush. I'll take a look into the server implications myself in the meantime, I'm just not confident I will be able to propose a good fix there if it gets complicated

@bdach
Copy link
Collaborator

bdach commented Dec 18, 2023

For starters:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants