-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mod search textbox having focus while settings are visible #25857
Conversation
Stopped arrow key adjust on slider bars from working. Also just felt wrong that you could type into an off-screen textbox.
The way this is implemented is pretty hacky and directly fails one of the tests (
2023-12-18.20-38-48.mp4I'm not sure what to make of that. Honestly seems like weird behaviour. |
Hmm, I guess? Depends on how you see it working ( Alternative would be making a tracking bool and handling focus more manually as per before. Should only require a few lines of change. |
I'd also accept having both mouse and keyboard hold focus and not give it back (plus removing that failing test; rest should start passing with that change I believe). So long as you can't drop the focus one way but not the other. |
#25880 also needs investigation here (potentially a regression from this PR as it was cherrypicked into the hotfix release) |
I've reverted to a safer approach to handling this, let me know what you think. Not 100% sure on the private method taking an argument, can refactor that if required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay. Have added appropriate test coverage.
Stopped arrow key adjust on slider bars from working.
Also just felt wrong that you could type into an off-screen textbox.
Closes #25842