Fix crash after changing audio track in editor #26219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes ppy#26213. Reproduction scenario: switch audio track in editor after timeline loads. Happens because `beatmap.Value.Track.Length` is 0 immediately after a track switch, until BASS computes the actual track length on the audio thread. Yes this is a hack. No I have no better immediate ideas how to address this otherwise.
|
Hmm, is this enough? I thought the track length is obtained on the audio thread, which may not have run in an unlucky scenario.. but maybe I'm wrong. |
|
You're correct. In practice this doesn't end up mattering because the timeline is not present on the setup screen, so the read is delayed until the compose screen is returned to. Again, yes this is a hack, no I have no better ideas on how to address this quickly. |
|
So the hope is that track length is populated by the time the user returns to compose? Might be worth handling the 0 length explicitly in the schedule, just to avoid a crash. Could even just re-schedule if we're feeling lucky. |
|
Sure, see how you find 99cddb6. |
peppy
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26213.
Reproduction scenario: switch audio track in editor after timeline loads.
Happens because
beatmap.Value.Track.Lengthis 0 immediately after a track switch, until BASS computes the actual track length on the audio thread.Yes this is a hack. No I have no better immediate ideas how to address this otherwise.